From b0daf507253fa4ec414bb77e8f176cda58b0f753 Mon Sep 17 00:00:00 2001 From: rootdarkarchon Date: Thu, 20 Oct 2022 15:32:32 +0200 Subject: [PATCH] check for admin/mod after checking for null, duh --- .../MareSynchronosServices/Discord/MareModule.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MareSynchronosServer/MareSynchronosServices/Discord/MareModule.cs b/MareSynchronosServer/MareSynchronosServices/Discord/MareModule.cs index 3d8a22b..9e99d34 100644 --- a/MareSynchronosServer/MareSynchronosServices/Discord/MareModule.cs +++ b/MareSynchronosServer/MareSynchronosServices/Discord/MareModule.cs @@ -136,7 +136,6 @@ public class MareModule : InteractionModuleBase var self = await db.LodeStoneAuth.Include(u => u.User).SingleOrDefaultAsync(u => u.DiscordId == id).ConfigureAwait(false); ulong userToCheckForDiscordId = id; - bool isAdminCall = self.User.IsModerator || self.User.IsAdmin; if (self == null) { @@ -145,6 +144,8 @@ public class MareModule : InteractionModuleBase return eb; } + bool isAdminCall = self.User.IsModerator || self.User.IsAdmin; + if ((optionalUser != null || uid != null) && !isAdminCall) { eb.WithTitle("Unauthorized");