From 8121b8c1f68c8c2e96536562e0621a1eab8b32cf Mon Sep 17 00:00:00 2001
From: rootdarkarchon <root.darkarchon@outlook.com>
Date: Sat, 18 Nov 2023 17:36:17 +0100
Subject: [PATCH] fix upload getting stuck

fix disposed semaphores
---
 .../Controllers/ServerFilesController.cs      | 38 +++++++++++++++----
 1 file changed, 31 insertions(+), 7 deletions(-)

diff --git a/MareSynchronosServer/MareSynchronosStaticFilesServer/Controllers/ServerFilesController.cs b/MareSynchronosServer/MareSynchronosStaticFilesServer/Controllers/ServerFilesController.cs
index 5f2630b..03c78c9 100644
--- a/MareSynchronosServer/MareSynchronosStaticFilesServer/Controllers/ServerFilesController.cs
+++ b/MareSynchronosServer/MareSynchronosStaticFilesServer/Controllers/ServerFilesController.cs
@@ -166,14 +166,26 @@ public class ServerFilesController : ControllerBase
         var existingFile = await _mareDbContext.Files.SingleOrDefaultAsync(f => f.Hash == hash);
         if (existingFile != null) return Ok();
 
-        SemaphoreSlim fileLock;
-        lock (_fileUploadLocks)
+        SemaphoreSlim? fileLock = null;
+        bool successfullyWaited = false;
+        while (!successfullyWaited && !requestAborted.IsCancellationRequested)
         {
-            if (!_fileUploadLocks.TryGetValue(hash, out fileLock))
-                _fileUploadLocks[hash] = fileLock = new SemaphoreSlim(1);
-        }
+            lock (_fileUploadLocks)
+            {
+                if (!_fileUploadLocks.TryGetValue(hash, out fileLock))
+                    _fileUploadLocks[hash] = fileLock = new SemaphoreSlim(1);
+            }
 
-        await fileLock.WaitAsync(requestAborted).ConfigureAwait(false);
+            try
+            {
+                await fileLock.WaitAsync(requestAborted).ConfigureAwait(false);
+                successfullyWaited = true;
+            }
+            catch (ObjectDisposedException)
+            {
+                _logger.LogWarning("Semaphore disposed for {hash}, recreating", hash);
+            }
+        }
 
         try
         {
@@ -257,7 +269,19 @@ public class ServerFilesController : ControllerBase
         }
         finally
         {
-            fileLock.Release();
+            try
+            {
+                fileLock?.Release();
+                fileLock?.Dispose();
+            }
+            catch (ObjectDisposedException)
+            {
+                // it's disposed whatever
+            }
+            finally
+            {
+                _fileUploadLocks.TryRemove(hash, out _);
+            }
         }
     }
 }
\ No newline at end of file