From 33a134608a0f73cc3d69e3293346b5d135bbc4fd Mon Sep 17 00:00:00 2001 From: rootdarkarchon Date: Sun, 18 Dec 2022 15:30:47 +0100 Subject: [PATCH] add more meaningful message for invalid data --- .../MareSynchronosServer/Hubs/MareHub.User.cs | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/MareSynchronosServer/MareSynchronosServer/Hubs/MareHub.User.cs b/MareSynchronosServer/MareSynchronosServer/Hubs/MareHub.User.cs index fcf0e9a..34c9bc9 100644 --- a/MareSynchronosServer/MareSynchronosServer/Hubs/MareHub.User.cs +++ b/MareSynchronosServer/MareSynchronosServer/Hubs/MareHub.User.cs @@ -1,4 +1,5 @@ -using System.Collections.Generic; +using System; +using System.Collections.Generic; using System.Linq; using System.Text.RegularExpressions; using System.Threading.Tasks; @@ -128,6 +129,8 @@ public partial class MareHub _logger.LogCallInfo(MareHubLogger.Args(visibleCharacterIds.Count)); bool hadInvalidData = false; + List invalidGamePaths = new(); + List invalidFileSwapPaths = new(); foreach (var replacement in characterCache.FileReplacements.SelectMany(p => p.Value)) { var invalidPaths = replacement.GamePaths.Where(p => !GamePathRegex().IsMatch(p)).ToArray(); @@ -142,7 +145,11 @@ public partial class MareHub } } - if (hadInvalidData) throw new HubException("Invalid data provided"); + if (hadInvalidData) throw new HubException("Invalid data provided, contact the appropriate mod creator to resolve those issues" + + Environment.NewLine + + string.Join(Environment.NewLine, invalidGamePaths.Select(p => "Invalid Game Path: " + p)) + + Environment.NewLine + + string.Join(Environment.NewLine, invalidGamePaths.Select(p => "Invalid FileSwap Path: " + p))); var allPairedUsers = await GetAllPairedUnpausedUsers().ConfigureAwait(false);