From 08c3bbde3c74dbf836c19ea68678d8f5a665348b Mon Sep 17 00:00:00 2001
From: Passive <passivemodding@gmail.com>
Date: Wed, 3 Aug 2022 16:34:38 +1000
Subject: [PATCH] Use single instance for rng in discord bot

---
 .../MareSynchronosServer/Discord/DiscordBot.cs               | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/MareSynchronosServer/MareSynchronosServer/Discord/DiscordBot.cs b/MareSynchronosServer/MareSynchronosServer/Discord/DiscordBot.cs
index fb92a46..47dbf53 100644
--- a/MareSynchronosServer/MareSynchronosServer/Discord/DiscordBot.cs
+++ b/MareSynchronosServer/MareSynchronosServer/Discord/DiscordBot.cs
@@ -26,6 +26,7 @@ namespace MareSynchronosServer.Discord
         private readonly IServiceProvider services;
         private readonly IConfiguration configuration;
         private readonly ILogger<DiscordBot> logger;
+        private readonly Random random;
         private string authToken = string.Empty;
         DiscordSocketClient discordClient;
         ConcurrentDictionary<ulong, string> DiscordLodestoneMapping = new();
@@ -39,6 +40,7 @@ namespace MareSynchronosServer.Discord
             this.configuration = configuration;
             this.logger = logger;
 
+            random = new();
             authToken = configuration.GetValue<string>("DiscordBotToken");
 
             discordClient = new(new DiscordSocketConfig()
@@ -131,8 +133,7 @@ namespace MareSynchronosServer.Discord
             var lodestoneAuth = db.LodeStoneAuth.SingleOrDefault(u => u.DiscordId == id);
             if (lodestoneAuth != null && DiscordLodestoneMapping.ContainsKey(id))
             {
-                Random rand = new();
-                var randomServer = LodestoneServers[rand.Next(LodestoneServers.Length)];
+                var randomServer = LodestoneServers[random.Next(LodestoneServers.Length)];
                 var response = await req.GetAsync($"https://{randomServer}.finalfantasyxiv.com/lodestone/character/{DiscordLodestoneMapping[id]}");
                 if (response.IsSuccessStatusCode)
                 {