delete empty files on failed downloads

MareSynchronos/WebAPI/ApIController.Functions.Files.cs

@@ -50,23 +50,31 @@ public partial class ApiController
         response.EnsureSuccessStatusCode();
 
         var fileName = Path.GetTempFileName();
-        var fileStream = File.Create(fileName);
+        try
-        await using (fileStream.ConfigureAwait(false))
         {
-            var bufferSize = response.Content.Headers.ContentLength > 1024 * 1024 ? 4096 : 1024;
+            var fileStream = File.Create(fileName);
-            var buffer = new byte[bufferSize];
+            await using (fileStream.ConfigureAwait(false))
-
-            var bytesRead = 0;
-            while ((bytesRead = await (await response.Content.ReadAsStreamAsync(ct).ConfigureAwait(false)).ReadAsync(buffer, ct).ConfigureAwait(false)) > 0)
             {
-                ct.ThrowIfCancellationRequested();
+                var bufferSize = response.Content.Headers.ContentLength > 1024 * 1024 ? 4096 : 1024;
+                var buffer = new byte[bufferSize];
 
-                await fileStream.WriteAsync(buffer.AsMemory(0, bytesRead), ct).ConfigureAwait(false);
+                var bytesRead = 0;
+                while ((bytesRead = await (await response.Content.ReadAsStreamAsync(ct).ConfigureAwait(false)).ReadAsync(buffer, ct).ConfigureAwait(false)) > 0)
+                {
+                    ct.ThrowIfCancellationRequested();
 
-                progress.Report(bytesRead);
+                    await fileStream.WriteAsync(buffer.AsMemory(0, bytesRead), ct).ConfigureAwait(false);
+
+                    progress.Report(bytesRead);
+                }
+
+                return fileName;
             }
-
+        }
-            return fileName;
+        catch
+        {
+            File.Delete(fileName);
+            throw;
         }
     }