From 5f18d736da24abea1d3dd9bda7036a6981d4d074 Mon Sep 17 00:00:00 2001
From: rootdarkarchon <root.darkarchon@outlook.com>
Date: Tue, 30 May 2023 19:28:04 +0200
Subject: [PATCH] minor fixes

---
 MareSynchronos/PlayerData/Handlers/PairHandler.cs        | 4 ++--
 .../PlayerData/Services/CacheCreationService.cs          | 9 +++++----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/MareSynchronos/PlayerData/Handlers/PairHandler.cs b/MareSynchronos/PlayerData/Handlers/PairHandler.cs
index b879aa5..dd472c5 100644
--- a/MareSynchronos/PlayerData/Handlers/PairHandler.cs
+++ b/MareSynchronos/PlayerData/Handlers/PairHandler.cs
@@ -278,7 +278,7 @@ public sealed class PairHandler : DisposableMediatorSubscriberBase
         _downloadCancellationTokenSource = _downloadCancellationTokenSource?.CancelRecreate() ?? new CancellationTokenSource();
         var downloadToken = _downloadCancellationTokenSource.Token;
 
-        Task.Run(async () =>
+        _ = Task.Run(async () =>
         {
             Dictionary<string, string> moddedPaths = new(StringComparer.Ordinal);
 
@@ -403,7 +403,7 @@ public sealed class PairHandler : DisposableMediatorSubscriberBase
             {
                 Logger.LogTrace("[BASE-{appBase}] {this} visibility changed, now: {visi}, cached data exists", appData, this, IsVisible);
 
-                Task.Run(async () =>
+                _ = Task.Run(async () =>
                 {
                     _lastGlamourerData = await _ipcManager.GlamourerGetCharacterCustomizationAsync(PlayerCharacter).ConfigureAwait(false);
                     ApplyCharacterData(appData, _cachedData!, true);
diff --git a/MareSynchronos/PlayerData/Services/CacheCreationService.cs b/MareSynchronos/PlayerData/Services/CacheCreationService.cs
index 45cf8ba..e0ff03e 100644
--- a/MareSynchronos/PlayerData/Services/CacheCreationService.cs
+++ b/MareSynchronos/PlayerData/Services/CacheCreationService.cs
@@ -36,7 +36,7 @@ public sealed class CacheCreationService : DisposableMediatorSubscriberBase
 
         Mediator.Subscribe<ClearCacheForObjectMessage>(this, (msg) =>
         {
-            Task.Run(() =>
+            _ = Task.Run(() =>
             {
                 Logger.LogTrace("Clearing cache for {obj}", msg.ObjectToCreateFor);
                 _playerData.FileReplacements.Remove(msg.ObjectToCreateFor.ObjectKind);
@@ -48,7 +48,6 @@ public sealed class CacheCreationService : DisposableMediatorSubscriberBase
         Mediator.Subscribe<ZoneSwitchStartMessage>(this, (msg) => _isZoning = true);
         Mediator.Subscribe<ZoneSwitchEndMessage>(this, (msg) => _isZoning = false);
 
-        Mediator.Subscribe<DelayedFrameworkUpdateMessage>(this, (msg) => ProcessCacheCreation());
         Mediator.Subscribe<CustomizePlusMessage>(this, async (_) =>
         {
             if (_isZoning) return;
@@ -93,6 +92,8 @@ public sealed class CacheCreationService : DisposableMediatorSubscriberBase
             .GetAwaiter().GetResult();
         _playerRelatedObjects[ObjectKind.Companion] = gameObjectHandlerFactory.Create(ObjectKind.Companion, () => dalamudUtil.GetCompanion(), true)
             .GetAwaiter().GetResult();
+
+        Mediator.Subscribe<DelayedFrameworkUpdateMessage>(this, (msg) => ProcessCacheCreation());
     }
 
     protected override void Dispose(bool disposing)
@@ -117,7 +118,7 @@ public sealed class CacheCreationService : DisposableMediatorSubscriberBase
         _honorificCts = new();
         var token = _honorificCts.Token;
 
-        Task.Run(async () =>
+        _ = Task.Run(async () =>
         {
             await Task.Delay(TimeSpan.FromSeconds(3), token).ConfigureAwait(false);
             await AddPlayerCacheToCreate().ConfigureAwait(false);
@@ -131,7 +132,7 @@ public sealed class CacheCreationService : DisposableMediatorSubscriberBase
         _palettePlusCts = new();
         var token = _palettePlusCts.Token;
 
-        Task.Run(async () =>
+        _ = Task.Run(async () =>
         {
             await Task.Delay(TimeSpan.FromSeconds(1), token).ConfigureAwait(false);
             await AddPlayerCacheToCreate().ConfigureAwait(false);